Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controller gen #179

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Update controller gen #179

merged 1 commit into from
Sep 16, 2024

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Jul 11, 2024 •
edited
Loading

The current version does not work on the latest ARM MacOS. There are some issues with go version and OS: kubernetes-sigs/controller-tools#888

make generate
/Users/martin/insights/frontend-operator/testbin/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x104f47a54]
goroutine 74 [running]:
go/types.(*Checker).handleBailout(0x140001dac00, 0x14000e69d18)

using the v15 fixest the problems

TODO:

  • fix which files needs tobe regenerated
  • fix the tests

@Hyperkid123 Hyperkid123 requested review from psav and adamrdrew July 11, 2024 14:50
@Hyperkid123
Copy link
Contributor Author

@psav I assume I have to re-generate some things. I see the controller gen version is referenced in a bunch of yaml
files

@Hyperkid123 Hyperkid123 marked this pull request as draft July 11, 2024 14:54
@maknop
Copy link
Contributor

maknop commented Jul 11, 2024 •
edited
Loading

I'm also getting this issue! I'm glad I'm not alone here. I'm working on running the make kuttl target within a Fedora image for the Konflux migration.

make generate produces the same result for me.

@Hyperkid123 Hyperkid123 force-pushed the update-controller-gen branch 9 times, most recently from ea33e72 to c108449 Compare July 12, 2024 07:13
@Hyperkid123
Copy link
Contributor Author

@maknop I think I got it working locally. (still need to fix konflux). Can you verify that this PR fixes your issue as well?

@Hyperkid123 Hyperkid123 force-pushed the update-controller-gen branch from c108449 to c82389f Compare July 12, 2024 07:19
@Hyperkid123 Hyperkid123 marked this pull request as ready for review July 12, 2024 07:26
@Hyperkid123
Copy link
Contributor Author

@psav @adamrdrew Ok I think I got it ready for review. I assume the Jenkins failure is still tied to the environment itself and not the changes I made. But I'd still like to wait until it works.

@maknop
Copy link
Contributor

maknop commented Jul 12, 2024

@Hyperkid123 That works for me. Thank you 😄

@Hyperkid123 Hyperkid123 force-pushed the update-controller-gen branch 11 times, most recently from 44e47c2 to 86a4b3c Compare August 13, 2024 10:31
@Hyperkid123 Hyperkid123 force-pushed the update-controller-gen branch 3 times, most recently from 9d85f45 to c0f2600 Compare August 13, 2024 11:12
@Hyperkid123 Hyperkid123 force-pushed the update-controller-gen branch 7 times, most recently from 4a65143 to 3df009a Compare September 16, 2024 07:43
@psav
Copy link
Collaborator

psav commented Sep 16, 2024

Approved - we should ensure that all our operators are updated to new "standards" regularly.

@Hyperkid123 Hyperkid123 merged commit 904a776 into RedHatInsights:main Sep 16, 2024
9 checks passed
@Hyperkid123 Hyperkid123 deleted the update-controller-gen branch September 16, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psav psav psav approved these changes

@adamrdrew adamrdrew Awaiting requested review from adamrdrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hyperkid123 @maknop @psav